Ankitml/git graph awareness #3
Conversation
Add GitGraphAnalyzer class for finding previous benchmarks based on git ancestry instead of execution time. This fixes release branch comparisons where PRs were comparing against wrong baseline commits. - Add src/gitGraph.ts with git analysis functions - Modify addBenchmarkEntry.ts to use git-graph aware previous benchmark selection - Update default_index_html.ts to sort visualization data by commit timestamp Fixes #3769
Add comprehensive tests for GitGraphAnalyzer and addBenchmarkEntry integration. All 227 tests pass successfully.
Co-authored-by: Stu Hood <[email protected]> Signed-off-by: Ankit <[email protected]>
stuhood
left a comment
stuhood
left a comment
There was a problem hiding this comment.
Thanks, although it looks like there is some code that should be removed around sorting by timestamps?
If the "insert new datapoint" code always runs, then there should never be a need to sort the entire dataset, because it should be created in inserted order...?
It is a bit disorganized but Ideally we should keep both, just because at some point we can upstream it. In that case sorting method would be some sort of config to choose. |
|
Organized it better, so making it upstream will be easier. |
Attempt to fix paradedb/paradedb#3769