Skip to content

Send PeerId via UMP #10145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2025
Merged

Send PeerId via UMP #10145

merged 7 commits into from
Nov 7, 2025

Conversation

@serban300
Copy link
Contributor

@serban300 serban300 commented Oct 28, 2025 •
edited
Loading

Resolves #7749

This PR propagates the network PeerId of the collator to the parachain inherent. Then the parachain runtime emits a UMP signal containing the collator PeerId.

@serban300 serban300 self-assigned this Oct 28, 2025
@serban300 serban300 changed the title [WIP] Send PeerId via UMP [WIP][Draft] Send PeerId via UMP Oct 28, 2025
@serban300 serban300 added the T9-cumulus This PR/Issue is related to cumulus. label Oct 28, 2025
@serban300 serban300 force-pushed the send-approved-peer-ump-signal branch 2 times, most recently from f19389c to 97bebcf Compare October 28, 2025 13:26
@serban300 serban300 force-pushed the send-approved-peer-ump-signal branch from 97bebcf to 730dfc3 Compare October 28, 2025 14:47
@serban300 serban300 force-pushed the send-approved-peer-ump-signal branch from 730dfc3 to 239752a Compare October 28, 2025 15:55
@serban300 serban300 changed the title [WIP][Draft] Send PeerId via UMP Send PeerId via UMP Oct 29, 2025
@serban300 serban300 requested a review from alindima October 29, 2025 07:08
sandreim
sandreim reviewed Oct 30, 2025
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @serban300 . Looks good, left a few comments.

alindima
alindima reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alindima alindima requested a review from skunert November 3, 2025 09:42
@serban300
Copy link
Contributor Author

serban300 commented Nov 4, 2025

/cmd prdoc --bump patch --audience node_operator --audience runtime_dev

github-actions bot and others added 2 commits November 4, 2025 12:28
@serban300
Copy link
Contributor Author

serban300 commented Nov 4, 2025

@sandreim thank you for the review ! Addressed your comments. Can you PTAL ?

sandreim
sandreim approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @serban300 !

@alindima
Copy link
Contributor

alindima commented Nov 5, 2025

I'll have another review tomorrow. Would be good if @skunert can also have a look as this is touching cumulus

@skunert
Copy link
Contributor

skunert commented Nov 5, 2025

I'll have another review tomorrow. Would be good if @skunert can also have a look as this is touching cumulus

Yes, also have it scheduled for tomorrow!

skunert
skunert approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@skunert skunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good! Do we already use this on the rc or is it in preparation of more collator-protocol changes to come?

@serban300
Copy link
Contributor Author

serban300 commented Nov 6, 2025

Logic looks good! Do we already use this on the rc or is it in preparation of more collator-protocol changes to come?

Thanks for the review !

The ApprovedPeer signal, is already supported on the RC, yes. But more changes will come as well.

@serban300 serban300 added this pull request to the merge queue Nov 7, 2025
Merged via the queue into paritytech:master with commit 5d5a639 Nov 7, 2025
240 of 247 checks passed
@serban300 serban300 deleted the send-approved-peer-ump-signal branch November 7, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skunert skunert skunert approved these changes

@alindima alindima alindima approved these changes

@sandreim sandreim sandreim approved these changes

Assignees

@serban300 serban300

Labels

T9-cumulus This PR/Issue is related to cumulus.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Collator Protocol Revamp: send PeerId via UMP

4 participants

@serban300 @alindima @skunert @sandreim