Fix/9548 auto renewal persistence #10176
Open
+103
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9548
This PR fixes the auto-renewal behavior in the broker pallet to match the documented behavior.
Problem: When auto-renewal fails due to insufficient funds or other errors, the system disables the auto-renewal setting entirely, requiring manual re-enablement.
Solution: The auto-renewal setting now persists across multiple periods even when renewal attempts fail, as stated in the documentation: "Even if an auto-renewal attempt fails, the auto-renewal setting remains active for subsequent sales."
Integration
For downstream projects using pallet-broker:
Review Notes
Changes made:
renew_cores()intick_impls.rsto returnSome(AutoRenewalRecord)instead ofNoneon failuresnext_renewaltosale.region_endfor retry in the next periodauto_renewal_worksto expect new behaviorauto_renewal_persists_after_failureto verify the fixBefore:
After:
Checklist