libp2p: Register bitswap protocol #10717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we only register the protocol properly for litep2p. What I don't get, why do we need the extra `bitswap_config` field and not just register the protocol directly as req-resp protocol.
Member
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
bkchr
commented
Jan 1, 2026
Contributor
@dmitry-markin is this still relevant: #9916 (comment)? Relates to: #9837 |
Member
Author
Good points. I did not try with any official ipfs node, but with my test use case I could use the bitswap protocol this way. |
Contributor
|
libp2p implementation of Bitswap is broken, it doesn't make sense to register it as a request-response protocol because the response comes over a different substream than the request was sent through. I.e., Bitswap is not a request-response protocol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we only register the protocol properly for litep2p. What I don't get, why do we need the extra
bitswap_configfield and not just register the protocol directly as req-resp protocol.