-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Penpal] cleanup XCM config setup regarding assets #10726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clangenb
wants to merge
120
commits into
paritytech:master
Choose a base branch
from
clangenb:cl/penpal-xcm-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,292
−998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create_pool_with_wnd_on`
…_different_local_account
Contributor
Author
|
Wow, this turned out to be much more involved than expected, however, I think it is ready for review now. It is only the two xcm-dry-run tests that are still failing, where I would love to get some input. @franciscoaguirre , @acatangiu tagging you as I believe this is your domain. ;) |
Contributor
|
No issues found. |
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump minor |
…time_dev --bump minor'
Contributor
Author
|
/cmd label T10-tests T15-bridges T6-XCM |
…ance is unchanged
…ot fix the tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T6-XCM
This PR/Issue is related to XCM.
T10-tests
This PR/Issue is related to tests.
T15-bridges
This PR/Issue is related to bridges.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7314 by implementing all the subtasks mentioned in #7314 (comment).
Changes
Essentially, the main driver of all changes is that we adjust the Penpal runtime as follows:
Assetsand theForeignAssetspallet into one pallet calledAssets, as the local assets can also be identified with a location starting withparents: 0.Test Changes
I tried to keep the changes minimal in the tests in order to not harm any previously established invariants. Hence, in most cases I just did: