Skip to content

Conversation

@paritytech-release-backport-bot

Backport #10711 into stable2512 from acatangiu.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10711-to-stable2512
git worktree add --checkout .worktree/backport-10711-to-stable2512 backport-10711-to-stable2512
cd .worktree/backport-10711-to-stable2512
git reset --hard HEAD^
git cherry-pick -x 0310b4655e659a3d3290a76ba60d5258b603857b
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 6, 2026
@github-actions github-actions bot requested a review from acatangiu January 6, 2026 09:48
Parametrize pallet-assets::set_reserves() weight based on number of
reserves provided instead of always assuming worst-case.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 0310b46)
@acatangiu acatangiu force-pushed the backport-10711-to-stable2512 branch from f0583c2 to def963e Compare January 6, 2026 10:24
@acatangiu acatangiu marked this pull request as ready for review January 6, 2026 10:24
@acatangiu acatangiu requested a review from a team as a code owner January 6, 2026 10:24
@acatangiu acatangiu changed the title [stable2512] Backport #10711 [stable2512] Backport #10711: Fix benchmarking for pallet-assets::set_reserves() Jan 6, 2026
@acatangiu acatangiu enabled auto-merge (squash) January 6, 2026 10:26
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@EgorPopelyaev
Copy link
Contributor

@acatangiu Hi Adrian, is it ok to downgrade the minor bumps to patch where the semver check it suggests or should those be kept as minor?

@acatangiu
Copy link
Contributor

ok to downgrade to patch yes

@acatangiu acatangiu merged commit 2b01b65 into stable2512 Jan 7, 2026
243 of 253 checks passed
@acatangiu acatangiu deleted the backport-10711-to-stable2512 branch January 7, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants