Fix claim_rewards_to benchmark to enable Snowbridge reward claims
#10952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
commented
Jan 31, 2026
| // Measured: `0` | ||
| // Measured: `297` | ||
| // Estimated: `0` | ||
| // Minimum execution time: 18_446_744_073_709_551_000 picoseconds. |
Contributor
Author
There was a problem hiding this comment.
claim_rewards_to is effectively disabled.
Contributor
Author
|
Polkadot runtimes PR here: sigurpol/runtimes#2 |
bkchr
approved these changes
Jan 31, 2026
| Self::deposit_account(rewards_account.clone(), reward); | ||
|
|
||
| None | ||
| Some(bridge_common_config::BridgeRewardBeneficiaries::LocalAccount( |
Member
There was a problem hiding this comment.
In what configuration does it makes sense that this function return None? :D
Contributor
Author
There was a problem hiding this comment.
I am not completely sure. My guess is this what stub code and had to be updated once claim_rewards_to was implemented, and I missed it.
@bkontur may you confirm, just want to make sure I'm not affecting anything on the P<>K bridge relayers side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
prepare_rewards_accountbenchmark helper was returningNone, causingclaim_rewards_toto be assignedWeight::MAXand effectively disabling the extrinsic. This fix returns a valid beneficiary account, enabling Snowbridge relayers to claim rewards to AssetHub as intended.