cumulus: resubmission store - #12091
Merged
Merged
Conversation
For simplicity, reasoning and efficiency.
+ Refactor/cleanup + some docs.
parents Remove per-parachain tracking of allowed relay parents in backing implicit view. Allowed relay parents are now computed per relay parent (globally) based on scheduling lookahead, rather than per parachain. Changes: - Remove `collating_for` parameter and para_id tracking from View - Update all callers to remove para_id arguments - Refactor tests with helper functions to reduce ~150 lines of duplication - Add comprehensive documentation to tests explaining expected behavior - Clarify `paths_via_relay_parent` returns full paths from oldest block to leaf This simplification aligns with the reality that all parachains share the same allowed relay parent windows at a given relay chain block.
+ Fix a typo.
alindima
reviewed
Jun 29, 2026
skunert
reviewed
Jul 1, 2026
skunert
left a comment
skunert
left a comment
Contributor
There was a problem hiding this comment.
Overall looking pretty good! Left some small comments.
8 tasks
iulianbarbu
reviewed
Jul 3, 2026
iulianbarbu
left a comment
iulianbarbu
left a comment
Contributor
There was a problem hiding this comment.
Very nice work, left just a few observations. Nothing outstanding. 🚀
iulianbarbu
reviewed
Jul 3, 2026
iulianbarbu
reviewed
Jul 3, 2026
alindima
approved these changes
Jul 8, 2026
iulianbarbu
approved these changes
Jul 8, 2026
iulianbarbu
left a comment
iulianbarbu
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 🚀 Just that I left my thoughts on how to approach both concerns of storing pvd data at relay parents in the store (meaning of block-builder and resubmissions). I can open an issue and address it afterwards if it sounds reasonable.
mchristou
enabled auto-merge
July 8, 2026 14:53
iulianbarbu
reviewed
Jul 9, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 13, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12034.
Adds
cumulus-client-resubmission-storewhich records what a collator needs to resubmit a collation for an unincluded parablock.For each imported parablock, keyed by its block hash, it persists: