Remove compact encoding bound from BaseArithmetic - #12394
Open
rossbulat wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
cc'ing @xlc for review as he opened the original issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1144.
This removes the compact-encoding requirement from
BaseArithmetic, allowing signed integer types to satisfy the general arithmetic traits. Compact encoding remains required on the unsigned arithmetic traits and at the specific call sites that actually compact-encode values.Changes
HasCompactfromBaseArithmetic.HasCompactto:AtLeast8BitUnsignedAtLeast16BitUnsignedAtLeast32BitUnsignedpallet_timestamp::Config::Momentpallet_indices::Config::AccountIndexbp_runtime::Chain::NonceHasCompact<Type: DecodeWithMemTracking>where compact-decoded types participate in memory-tracked decoding.Rationale
AtLeast32Bitis the signed-or-unsigned arithmetic trait, but it previously inheritedHasCompactthroughBaseArithmetic. Since compact encoding is only implemented for unsigned integer types today, this prevented signed integers such asi128from implementingAtLeast32Bit.The compact-encoding requirement belongs on unsigned-specific traits and concrete compact-encoding use sites, not on the shared base arithmetic trait.
Validation