[pallet-revive] eth-rpc: fix latest block initialization and reduce per-block RPC calls. - #12742
Open
marian-radu wants to merge 9 commits into
Open
[pallet-revive] eth-rpc: fix latest block initialization and reduce per-block RPC calls.#12742marian-radu wants to merge 9 commits into
latest block initialization and reduce per-block RPC calls.#12742marian-radu wants to merge 9 commits into
Conversation
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
marian-radu
added
the
T7-smart_contracts
marian-radu
changed the title
latest being initialized from the finalized blocklatest block initialization and reduce per-block RPC calls.
Contributor
Author
|
/cmd prdoc --audience runtime_dev --bump patch |
…time_dev --bump patch'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the finalized and best blocks were initialized using
at_current_block(), which in subxt 0.50 returns the finalized block; the best block therefore started behind the chain tip and served stale blocks until the subscription caught up. Also reduce the number of RPC calls by reusing the already resolved block infetch_receipt_data, and by only requesting receipt data when a block contains EVM extrinsics.Changes
latest_blockfrom the actual best block.update_latestmonotonic, so the startup backlog replayed by subxt 0.50's chainHead subscription can no longer walk a head backwards.fetch_receipt_datainstead of a hash.differential-testsjob timeout from 60 to 120 minutes; the full corpus no longer finishes within 60 minutes since the subxt 0.50 bump. Further investigation of the slowdown will be tackled separately.