More v3 candidates zombienet-sdk tests - #12743
Conversation
mchristou
added
R0-no-crate-publish-required
was that performed? all good?
I assume it runs fine locally? is it reliable over multiple runs? |
| }; | ||
|
|
||
| #[rstest] | ||
| #[case::v2(None, false)] |
There was a problem hiding this comment.
let's have a single param named use_v3_candidates: bool and assume the chain name based on whether or not it's enabled
| assert_finality_lag(&old_para_node.wait_client().await?, 6).await?; | ||
|
|
||
| for (name, node) in [("collator-3000", ¶_node), ("old-collator-3000", &old_para_node)] { | ||
| node.wait_metric_with_timeout( |
There was a problem hiding this comment.
can we make the minimum value higher? the throughput expected earlier in this test is at least 40 backed candidates in 50 relay chain blocks so let's check that a higher numer of candidates is produced by each
There was a problem hiding this comment.
looks like the throughput drops though, please check why: https://github.com/paritytech/polkadot-sdk/actions/runs/30371378193/job/90338870619?pr=12743
2 participants
Coverage of #12164
Scenario 1: added in existing test:
v3_rolling_upgradeScenario 2/3: covered in #12695
Scenario 4: v3_old_validator_dispute_storm.rs
Scenario 5: manual test
Scenario 6: parameter changes added to doesnt_break_parachains_test
NOTE v3_old_validator_dispute_storm is expensive to add it in CI. Added here to run it manually while its still relevant