Remove pallet-scored-pool - #12746
Open
Ank4n wants to merge 2 commits into
Open
Conversation
This pallet is not used by any runtime in the repository, has had no functional changes in years (only mechanical maintenance touches), and has no known production users. Removes the crate, its workspace membership, and its umbrella crate re-export and features. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Ank4n
added
T2-pallets
sigurpol
approved these changes
Jul 28, 2026
sigurpol
left a comment
sigurpol
left a comment
Contributor
There was a problem hiding this comment.
RIP. I am fine with your approach of fast-tracking the removal. I would also be perfectly fine with the default deprecation checklist path if we want to play safer just in case.
Contributor
Author
|
Nice work Claude! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
pallet-scored-pool.Rationale, as raised in #12333 (comment):
RuntimeEventremoval, dep cleanup, Rust version bumps).pallet-membership,pallet-ranked-collective, andpallet-core-fellowship.This supersedes #12333, which fixes a sort-order bug in the pallet being removed here.
Changes
substrate/frame/scored-pool/pallet-scored-pooloptional dependency, feature,std/try-runtimepropagation, and re-export from thepolkadot-sdkumbrella crateNotes for reviewers
Per the deprecation checklist, the usual path is a hard-deprecation notice with a ~6 month removal window before removal. I've gone straight to removal here since the pallet is unused in-tree and has no known production users, but I'm happy to split this into a deprecate-then-remove sequence instead if reviewers prefer to follow the checklist strictly — the crate is published on crates.io, so external builders could in principle be depending on it.
pallet-scored-poolis intentionally not listed in the prdoccratessection:check-prdoc.pyvalidates crate names against the workspace, so a deleted crate cannot be listed there.🤖 Generated with Claude Code