Skip to content

Conversation

mbfakourii
Copy link
Member

Pull Request

Issue

Add support for Dart 3.6, 3.7; remove support for Dart 3.2, 3.3, 3.4, 3.5, 3.3

Closes: #1026

Approach

n/a

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Apr 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.72%. Comparing base (c388545) to head (36eadaf).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   43.37%   43.72%   +0.35%     
==========================================
  Files          61       61              
  Lines        3463     3465       +2     
==========================================
+ Hits         1502     1515      +13     
+ Misses       1961     1950      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbfakourii mbfakourii requested a review from a team April 19, 2025 12:34
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this miss the version bump of the SDK?

@@ -53,8 +47,13 @@ jobs:
run: (cd packages/dart && dart run build_runner build --delete-conflicting-outputs)
- name: Analyze code
run: dart analyze packages/dart --fatal-infos
- name: Lint For Fix Bug mocks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

@@ -18,36 +18,40 @@ topics:
- backend

environment:
sdk: ">=3.2.6 <4.0.0"
sdk: ^3.6.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure whether removing the upper bound is a good idea, but since even minor versions changes can be breaking, let's try.

@mtrezza mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Apr 19, 2025
@mtrezza
Copy link
Member

mtrezza commented May 18, 2025

@mbfakourii just a friendly ping, so we can get this merged.

@mbfakourii
Copy link
Member Author

mbfakourii commented Jun 27, 2025

@mtrezza

Sorry for the delay, I was busy. I think an automated CI is needed for these changes. What do you think?

@mtrezza
Copy link
Member

mtrezza commented Jun 29, 2025

@mbfakourii What do you mean by automated CI?

@mbfakourii
Copy link
Member Author

@mbfakourii What do you mean by automated CI?

I mean, this PR that was created should be done automatically.

@mtrezza
Copy link
Member

mtrezza commented Jul 17, 2025

@mbfakourii The only thing we currently automate in other repos is the version increment and release publishing. So that you don't need to change the package version and write a change log entry manually anymore. Do you mean that?

@kirkmorrow
Copy link

It's been 5 weeks since last update. Hope this isn't getting lost in the crowd.

@mbfakourii mbfakourii closed this Aug 27, 2025
@kirkmorrow
Copy link

kirkmorrow commented Aug 27, 2025

Closed with no commits? So support of Dart > 3.5 just goes out of plan?

@mtrezza
Copy link
Member

mtrezza commented Aug 27, 2025

@mbfakourii Was this PR ready for merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade parse_server_sdk_flutter dependency on parse_server_sdk from ^6.4.0 to ^7.0.0
3 participants