-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Flutter 3.13
, 3.16
, 3.19
; remove support for Flutter 3.3
, 3.7
#994
feat: Add support for Flutter 3.13
, 3.16
, 3.19
; remove support for Flutter 3.3
, 3.7
#994
Conversation
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
==========================================
+ Coverage 43.37% 43.43% +0.05%
==========================================
Files 61 61
Lines 3463 3463
==========================================
+ Hits 1502 1504 +2
+ Misses 1961 1959 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change since we are removing support for older flutter versions, right? Could you please rename the PR title to
feat: Add support for Flutter x.x, x.x; remove support for Flutter x.x, x.x
|
||
dependencies: | ||
flutter: | ||
sdk: flutter | ||
|
||
parse_server_sdk: ^5.1.3 | ||
parse_server_sdk: ^6.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we merge #993 first and then set this to ^7.0.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes ,this is a better method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can upgrade now and then let's see if the CI passes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the conflicts in flutter 3.10
with parse_server_sdk 7.0.0
, it is not possible to upgrade parse_server_sdk until Flutter 3.10 is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the procedure to go forward?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to wait until July 2024 to upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it will cause any problem and you can merge this PR
3.13
, 3.16
, 3.19
; remove support for Flutter 3.3
, 3.7
Yes, the title has also changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a changelog entry and bump the SDK version?
Added. |
… into compatibility-update-in-flutter
You may check this PR. |
Pull Request
Issue
Closes: #992
Approach
n/a
Tasks