fix: Does not allow sending the priority of 10 for notifications #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
==========================================
+ Coverage 93.53% 95.79% +2.25%
==========================================
Files 23 23
Lines 588 832 +244
==========================================
+ Hits 550 797 +247
+ Misses 38 35 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mtrezza this is ready for review |
mtrezza
changed the title
mtrezza
approved these changes
Feb 11, 2025
parseplatformorg
pushed a commit
that referenced
this pull request
Feb 11, 2025
## [6.4.3](6.4.2...6.4.3) (2025-02-11) ### Bug Fixes * Does not allow sending the priority of 10 for notifications ([#173](#173)) ([689ce37](689ce37))
|
🎉 This change has been released in version 6.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the priority of
10to be sent to the APN server. Previously, the library omitted the value of10because the APN server uses this value as default. For broadcast notifications, priority is required as a header field, or an error will be thrown.The original default behavior from a developer using the library is still the same for standard notifications. If the dev doesn't specify a priority, the default is still
10.Closes: #172