Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #5521 #6015

Closed
wants to merge 1 commit into from
Closed

Conversation

RaschidJFR
Copy link
Contributor

Test case for issue #5521

@dplewis
Copy link
Member

dplewis commented Sep 12, 2019

I don’t think a fix for this is possible but a workaround will fix your issue. Please see my previous comment

@RaschidJFR
Copy link
Contributor Author

Thanks, I saw your comment but I still have to dig into the code. Why not possible?

@dplewis
Copy link
Member

dplewis commented Sep 12, 2019

When subclassing calling super it is required to be the first line in a constructor.

Any attributes it receive will be set immediately, however calling this.set right after override that value.

Unless you can set your initial value before calling super we have have a fix but we can’t call anything before super.

@RaschidJFR
Copy link
Contributor Author

@dplewis I think the problem may start in ParseObject.fromJSON(). From this line on, only certain properties of otherAttributes are applied to the retrieved object: createdAt, updatedAt, etc. But not the custom properties (name in this case).

Then, deeper in the call stack, I see in ObjectStateMutations.commitServerChanges() that only object properties are being added to the objectCache. Any particular reason?

My first hypothesis would be to remove line 149 from ObjectStateMutations.js. Am I on the right track?

@RaschidJFR
Copy link
Contributor Author

RaschidJFR commented Sep 16, 2019

I'm closing this PR in favor of parse-community/Parse-SDK-JS/#924

@RaschidJFR RaschidJFR closed this Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants