(PC-31778) refacto wording after review

pass-culture · Sep 20, 2024 · d4062f0 · d4062f0
1 parent a83096b
commit d4062f0
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/...apshots__/features/bookings/pages/EndedBookings/EndedBookings.native.test.tsx.native-snap b/...apshots__/features/bookings/pages/EndedBookings/EndedBookings.native.test.tsx.native-snap
@@ -253,6 +253,7 @@ exports[`EndedBookings should render correctly 1`] = `
           },
           "token": "352UW5",
           "totalAmount": 1900,
+          "userReaction": null,
         },
         {
           "confirmationDate": "2021-02-15T23:01:37.925926",
@@ -297,6 +298,7 @@ exports[`EndedBookings should render correctly 1`] = `
           },
           "token": "352UW5",
           "totalAmount": 1900,
+          "userReaction": null,
         },
       ]
     }
@@ -787,6 +789,7 @@ exports[`EndedBookings should render correctly 1`] = `
               },
               "token": "352UW5",
               "totalAmount": 1900,
+              "userReaction": null,
             }
           }
           style={

diff --git a/src/features/bookings/fixtures/bookingsSnap.ts b/src/features/bookings/fixtures/bookingsSnap.ts
@@ -3,7 +3,6 @@ import type { ReadonlyDeep } from 'type-fest'
 import {
   BookingCancellationReasons,
   BookingsResponse,
-  ReactionTypeEnum,
   SubcategoryIdEnum,
   WithdrawalTypeEnum,
 } from 'api/gen'
@@ -108,7 +107,7 @@ export const bookingsSnap = toMutable({
       totalAmount: 1900,
       token: '352UW5',
       quantity: 10,
-      userReaction: ReactionTypeEnum.LIKE,
+      userReaction: null,
       stock: {
         id: 150230,
         price: 400,

diff --git a/src/features/bookings/pages/Bookings/Bookings.native.test.tsx b/src/features/bookings/pages/Bookings/Bookings.native.test.tsx
@@ -163,7 +163,10 @@ describe('Bookings', () => {
       fireEvent.press(await screen.findByText('En cours'))
 
       expect(mockMutate).toHaveBeenCalledWith({
-        reactions: [{ offerId: 147874, reactionType: ReactionTypeEnum.NO_REACTION }],
+        reactions: [
+          { offerId: 147874, reactionType: ReactionTypeEnum.NO_REACTION },
+          { offerId: 147874, reactionType: ReactionTypeEnum.NO_REACTION },
+        ],
       })
     })
   })

diff --git a/src/features/bookings/pages/Bookings/Bookings.tsx b/src/features/bookings/pages/Bookings/Bookings.tsx
@@ -31,12 +31,12 @@ export function Bookings() {
         .filter((ended_booking) => ended_booking.userReaction === null)
         .map((booking) => booking.stock.offer.id) ?? []
 
-    const bookingsTest = bookingsToUpdate.map((bookingId) => ({
+    const mutationPayload = bookingsToUpdate.map((bookingId) => ({
       offerId: bookingId,
       reactionType: ReactionTypeEnum.NO_REACTION,
     }))
-    if (bookingsTest.length > 0) {
-      addReaction({ reactions: bookingsTest })
+    if (mutationPayload.length > 0) {
+      addReaction({ reactions: mutationPayload })
     }
   }, [addReaction, bookings?.ended_bookings])
 

diff --git a/src/features/bookings/pages/Bookings/Bookings.web.test.tsx b/src/features/bookings/pages/Bookings/Bookings.web.test.tsx
@@ -52,7 +52,7 @@ describe('Bookings', () => {
     renderBookings(bookingsSnap)
 
     await waitFor(() => {
-      expect(useBookings).toHaveBeenCalledTimes(1)
+      expect(useBookings).toHaveBeenCalledTimes(2)
     })
   })