-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PC-31854) feat(venue): add video section + fake video player component #6910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Comparison ReportSignificant Changes To Render Duration
Show details
Meaningless Changes To Render DurationShow entries
Show details
Changes To Render CountThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
mmeissonnier-pass
force-pushed
the
feat/PC-31854-venue-video-fakedoor
branch
2 times, most recently
from
September 20, 2024 15:25
63572e1
to
77ee8f8
Compare
mmeissonnier-pass
force-pushed
the
feat/PC-31854-venue-video-fakedoor
branch
from
September 20, 2024 15:38
77ee8f8
to
72ba039
Compare
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
yleclercq-pass
approved these changes
Sep 23, 2024
xlecunff-pass
pushed a commit
that referenced
this pull request
Sep 29, 2024
…nt (#6910) Co-authored-by: Mathieu Meissonnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-31854
Flakiness
If I had to re-run tests in the CI due to flakiness, I add the incident on Notion
Checklist
I have:
Screenshots
Kapture.2024-09-20.at.17.14.34.mp4