Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PC-31854) feat(venue): add video section + fake video player component #6910

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mmeissonnier-pass
Copy link
Contributor

@mmeissonnier-pass mmeissonnier-pass commented Sep 20, 2024

Link to JIRA ticket: https://passculture.atlassian.net/browse/PC-31854

  • Creation d'un composant FakeVideoPlayer
  • Intégration dans la page Venue
  • Changement dynamique de l'image de background en fonction de la catégorie du lieu
  • Ajouter d'un nouveau FF "wipFakeDoorVideoVenue"
  • Affichage uniquement côté natif

Flakiness

If I had to re-run tests in the CI due to flakiness, I add the incident on Notion

Checklist

I have:

  • Made sure my feature is working on web.
  • Made sure my feature is working on mobile (depending on relevance : real or virtual devices)
  • Written unit tests native (and web when implementation is different) for my feature.
  • Added a screenshot for UI tickets or deleted the screenshot section if no UI change
  • If my PR is a bugfix, I add the link of the "résolution de problème sur le bug" on Notion

Screenshots

Kapture.2024-09-20.at.17.14.34.mp4

Copy link

github-actions bot commented Sep 20, 2024

Performance Comparison Report

Significant Changes To Render Duration

Name Render Duration Render Count
Performance test for Offer page 177.4 ms → 172.8 ms (-4.6 ms, -2.6%) 4 → 4
Show details
Name Render Duration Render Count
Performance test for Offer page Baseline
Mean: 177.4 ms
Stdev: 4.5 ms (2.6%)
Runs: 184 182 181 181 179 176 174 173 172 172

Current
Mean: 172.8 ms
Stdev: 5.9 ms (3.4%)
Runs: 182 181 178 173 173 171 170 169 166 165
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Meaningless Changes To Render Duration

Show entries
Name Render Duration Render Count
Performance test for EndedBookings page 33.6 ms → 35.7 ms (+2.1 ms, +6.3%) 7 → 7
Performance test for Bookings page 44.6 ms → 45.4 ms (+0.8 ms, +1.8%) 7 → 7
Performance test for Profile page 6.0 ms → 6.1 ms (+0.1 ms, +1.7%) 5 → 5
Search Landing Page - Performance test for Search Landing page 14.2 ms → 14.1 ms (-0.1 ms, -0.7%) 5 → 5
Performance test for Venue page 2.7 ms → 2.4 ms (-0.3 ms, -11.1%) 1 → 1
Search Results - Performance test for Search Results page 15.1 ms → 14.6 ms (-0.5 ms, -3.3%) 5 → 5
Performance test for Favorites page 68.8 ms → 66.3 ms (-2.5 ms, -3.6%) 6 → 6
Show details
Name Render Duration Render Count
Performance test for EndedBookings page Baseline
Mean: 33.6 ms
Stdev: 1.3 ms (3.8%)
Runs: 36 34 34 34 34 34 33 33 33 31

Current
Mean: 35.7 ms
Stdev: 2.8 ms (7.7%)
Runs: 42 37 37 36 36 36 34 33 33 33
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Performance test for Bookings page Baseline
Mean: 44.6 ms
Stdev: 2.6 ms (5.8%)
Runs: 49 49 45 45 45 43 43 43 42 42

Current
Mean: 45.4 ms
Stdev: 1.6 ms (3.6%)
Runs: 48 47 47 46 46 45 44 44 44 43
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Performance test for Profile page Baseline
Mean: 6.0 ms
Stdev: 0.9 ms (15.7%)
Runs: 7 7 7 6 6 6 6 6 5 4

Current
Mean: 6.1 ms
Stdev: 0.9 ms (14.4%)
Runs: 7 7 7 6 6 6 6 6 6 4
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Search Landing Page - Performance test for Search Landing page Baseline
Mean: 14.2 ms
Stdev: 1.8 ms (12.8%)
Runs: 18 16 15 14 14 14 14 13 12 12

Current
Mean: 14.1 ms
Stdev: 1.2 ms (8.5%)
Runs: 16 16 15 14 14 14 13 13 13 13
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Venue page Baseline
Mean: 2.7 ms
Stdev: 0.5 ms (17.9%)
Runs: 3 3 3 3 3 3 3 2 2 2

Current
Mean: 2.4 ms
Stdev: 0.7 ms (29.1%)
Runs: 3 3 3 3 3 2 2 2 2 1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Search Results - Performance test for Search Results page Baseline
Mean: 15.1 ms
Stdev: 1.0 ms (6.6%)
Runs: 17 16 16 15 15 15 15 14 14 14

Current
Mean: 14.6 ms
Stdev: 1.3 ms (8.7%)
Runs: 17 16 15 15 15 14 14 14 13 13
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Performance test for Favorites page Baseline
Mean: 68.8 ms
Stdev: 6.6 ms (9.6%)
Runs: 86 72 69 68 68 67 66 65 64 63

Current
Mean: 66.3 ms
Stdev: 1.7 ms (2.6%)
Runs: 69 68 67 67 67 66 66 65 65 63
Baseline
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Current
Mean: 6
Stdev: 0 (0.0%)
Runs: 6 6 6 6 6 6 6 6 6 6

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 72ba039

@mmeissonnier-pass mmeissonnier-pass force-pushed the feat/PC-31854-venue-video-fakedoor branch 2 times, most recently from 63572e1 to 77ee8f8 Compare September 20, 2024 15:25
@mmeissonnier-pass mmeissonnier-pass marked this pull request as ready for review September 20, 2024 15:38
Copy link

sonarcloud bot commented Sep 20, 2024

Copy link

sonarcloud bot commented Sep 20, 2024

@mmeissonnier-pass mmeissonnier-pass merged commit b11e692 into master Sep 23, 2024
52 checks passed
@mmeissonnier-pass mmeissonnier-pass deleted the feat/PC-31854-venue-video-fakedoor branch September 23, 2024 08:08
xlecunff-pass pushed a commit that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants