(PC-32974)[API] fix: broken date filters on offer's page #15014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The join on Offer broke things since it missed the filters on it because there was already an alias used on offer. It looks like the second join got all the stocks all the time, making the filters on date useless. The test did not detect it because it was only making sure the offers were OK within the time range but was not checking if the offers were correctly ignored when outside the time range.
lmaubert-pass
approved these changes
Nov 13, 2024
tcoudray-pass
approved these changes
Nov 13, 2024
| ) | ||
| stock_query = stock_query.outerjoin( | ||
| offerers_models.OffererAddress, | ||
| offer_alias.offererAddressId == offerers_models.OffererAddress.id, |
There was a problem hiding this comment.
On n'est d'accord que le isouter était inutile parce que l'on utilise la méthode outerjoin et non join ?
There was a problem hiding this comment.
C'est ce que je comprends aussi sur les parametres de https://docs.sqlalchemy.org/en/13/orm/query.html#sqlalchemy.orm.query.Query.join
isouter=False – If True, the join used will be a left outer join, just as if the Query.outerjoin() method were called.
xordoquy-pass
deleted the
PC-32974-pro-page-offres-et-reservations-a-verifier-le-filtre-par-date-est-ko
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32974
The join on Offer broke things since it missed the filters on it because there was already an alias used on offer.
It looks like the second join got all the stocks all the time, making the filters on date useless.
The test did not detect it because it was only making sure the offers were OK within the time range but was not checking if the offers were correctly ignored when outside the time range.
Vérifications