ci: add inline comments to describe the "Get SDK Version" job logic

passageidentity · Jan 27, 2025 · 9a5448b · 9a5448b
1 parent 93010f3
commit 9a5448b
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/.github/workflows/on-pull-request.yml b/.github/workflows/on-pull-request.yml
@@ -66,12 +66,14 @@ jobs:
         if: ${{ steps.check_permission.outputs.require-result == 'true' }}
         run: |
           line=$(head -n 1 go.mod)
-          go_mod_version=${line##*/v}
-          manifest_version=$(jq -r '."."' .release-please-manifest.json | cut -d. -f1)
+          go_mod_major_version=${line##*/v}
+          manifest_major_version=$(jq -r '."."' .release-please-manifest.json | cut -d. -f1)
 
+          # Only set version if the go.mod major version was bumped in the PR
+          # meaning that an override for the local registry should be set to make it work in e2es
           version=''
-          if [[ $go_mod_version -gt $manifest_version ]]; then
-            version="${go_mod_version}.0.0"
+          if [[ $go_mod_major_version -gt $manifest_major_version ]]; then
+            version="${go_mod_major_version}.0.0"
           fi
 
           echo "version=$version" >> $GITHUB_OUTPUT