Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dev container #101

Merged
merged 2 commits into from
Nov 15, 2024
Merged

chore: add dev container #101

merged 2 commits into from
Nov 15, 2024

Conversation

ctran88
Copy link
Contributor

@ctran88 ctran88 commented Nov 14, 2024

What's New?

  • Adds dev container configuration to bootstrap the dev environment
  • Removes unused pre-commit config file

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional context

@ctran88 ctran88 force-pushed the PSG-4650-dev-container branch from 8650f80 to c3b2cb3 Compare November 14, 2024 18:14
@ctran88 ctran88 marked this pull request as ready for review November 14, 2024 18:15
@ctran88 ctran88 requested a review from a team November 14, 2024 18:53
Copy link
Contributor

@tdeshong tdeshong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled the branch down

  • ran all the test ✅
  • generated sdk from openapi.json artifact ✅

@ctran88 ctran88 merged commit de33d0e into main Nov 15, 2024
5 checks passed
@ctran88 ctran88 deleted the PSG-4650-dev-container branch November 15, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants