Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address Node Feedback #190

Merged
merged 9 commits into from
Dec 5, 2024
Merged

fix: Address Node Feedback #190

merged 9 commits into from
Dec 5, 2024

Conversation

flanagankp
Copy link
Contributor

@flanagankp flanagankp commented Dec 5, 2024

BEGIN_COMMIT_OVERRIDE
chore: add ability to override merged commit message
END_COMMIT_OVERRIDE

What's New?

Addresses minor issues with Node accessor modifiers, type and arg names, uses parseError pattern established in flex-node, and fixes some doc strings.

Additionally:

  • Reorgs all generated type re-exports to be co-located next to the class that uses them.
  • Restores original error messages around JWT validation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • New and existing integration and unit tests pass locally with my changes

Additional context

@flanagankp flanagankp requested a review from a team December 5, 2024 19:02
src/classes/Passage/Passage.ts Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Dec 5, 2024

@flanagankp flanagankp merged commit 0cd94ec into main Dec 5, 2024
6 checks passed
@flanagankp flanagankp deleted the psg-5456-node-cleanup branch December 5, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants