PatchWork AutoFix #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patched-admin
force-pushed
the
autofix-gemini-1.5-pro-latest
branch
from
47d403f to
b0c09fa
Compare
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def check_password(self, password: str): | ||
| return self.pwd_hash == md5(password.encode('utf-8')).hexdigest() | ||
| return self.pwd_hash == scrypt(password.encode('utf-8'), salt=b'some_salt', n=16384, r=8, p=1).hex() |
Check failure
Code scanning / SonarCloud
Password hashing functions should use an unpredictable salt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request from patched fixes 3 issues.
Fix: Harden redis service configuration
Added security hardening configurations to the 'redis' service. It now includes 'no-new-privileges: true' to prevent privilege escalation via setuid or setgid binaries. Additionally, 'read_only: true' is added to make the redis service's root filesystem read-only, enhancing security by preventing arbitrary file write access.Fix: Use parameterized query in Student.create to prevent SQL injection
Replaced string formatting in the SQL query of theStudent.createmethod with a parameterized query to prevent potential SQL injection vulnerabilities. The query now uses placeholders and passes thenameparameter safely to the database driver.feat: Use scrypt for password hashing
Replaced the insecure MD5 hashing algorithm with scrypt for password hashing to enhance security.