Add [test] and update CONTRIBUTING #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This LGTM! I've been meaning to convert this over for a while. Thank you for tweaking this :)
Could you also (a) delete tests/requirements.txt and (b) update https://github.com/patrick-kidger/equinox/blob/main/.github/workflows/run_tests.yml appropriately?
|
PTAL |
|
LGTM! Thanks for the improvement :) |
|
Of course, I should probably do it in my own projects... |
Merged
patrick-kidger
added a commit
that referenced
this pull request
Sep 14, 2024
This reverts commit 5a40d2e.
|
Unfortunately I had to revert this one. The problem arises with equinox/.github/workflows/release.yml Line 19 in 5a40d2e pip install ., as e.g. its pyproject.toml file may not even be present in the wheel. (In practice the first error was Hatch complaining about the lack of LICENSE file.)
Ah well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to set up dev env.