Add overloads to eqx.combine #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilGirdhar
force-pushed
the
combine_same
branch
from
d28722b
to
de6c21a
Compare
In the common case wherein all trees have the same structure, the return should have the same structure. Helps type checking a lot.
NeilGirdhar
force-pushed
the
combine_same
branch
from
de6c21a
to
24525e0
Compare
|
LGTM! Thank you for the improvement :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the common case wherein all trees have the same structure, the return should have the same structure. Helps type checking a lot.