Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove mustache in favour of handlebars #1455

Draft
wants to merge 42 commits into
base: dev
Choose a base branch
from
Draft

refactor: remove mustache in favour of handlebars #1455

wants to merge 42 commits into from
+483 −633

Conversation

mfranzke
Copy link
Contributor

@mfranzke mfranzke commented Dec 25, 2022 •
edited
Loading

Closes #1239 and #1436

Summary of changes:

tbd

@mfranzke mfranzke self-assigned this Dec 25, 2022
@mfranzke mfranzke linked an issue Dec 25, 2022 that may be closed by this pull request
Deprecate Mustache as default engine #1239
Open
@mfranzke mfranzke added the dependencies Pull requests that update a dependency file label Dec 26, 2022
@mfranzke mfranzke mentioned this pull request Dec 26, 2022
Merged
mfranzke and others added 2 commits December 27, 2022 23:00
@mfranzke
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
014ea88
@JosefBredereck
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c30b78c
@mfranzke mfranzke added the breaking ❗ Use this labe if the change will break the current pattern lab behavior label Dec 28, 2022
@mfranzke
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine
e4ff89e
@mfranzke
fix: incorrect path

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
98ce349
@mfranzke
fix: incorrect path

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
04a7c95
@mfranzke
fix: incorrect path

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
65b4690
@mfranzke
fix: incorrect path
74a3cad
@mfranzke
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8fb16eb
@mfranzke
chore(CI/CD): let's not install mustache engine anymore
7f9fd5a
@mfranzke
refactor: need to switch to the handlebars engine
fe8329c
@mfranzke
refactor: switched to hbs fileextension in configurations
4835d3b
@mfranzke
refactor: switching from mustache engine to handlebars
c78ebc6
@mfranzke
refactor(docs): switching from mustache to handlebars
30be5bc
@mfranzke
test: switching from mustache to handlebars
2c318bd
@mfranzke
refactor: revert the workaround out of !1256
853a493 
#1256
mfranzke and others added 14 commits December 31, 2022 08:19
@mfranzke
Update pattern_engines.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
560c7ec
@mfranzke
Merge branch '1239-deprecate-mustache-as-default-engine' of https://g…
59fbbf1 
…ithub.com/pattern-lab/patternlab-node into 1239-deprecate-mustache-as-default-engine
@mfranzke
Restore packages/core/test/engine_mustache_tests.js

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
62240b1
@mfranzke
refactor(test): updated syntax to handlebars
bd7dfd9
@mfranzke
chore: set this explicitly, aligned with the others
764d0f2
@mfranzke
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6a14990
@mfranzke
test: updated test case files
82916a1
@mfranzke
test: we need to ignore our handlebars files that contain partials re…
b5a4426 
…ferences
@mfranzke
chore: simple comment
781f0b0
@mfranzke
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
054feb3
@mfranzke
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6839abd
@mfranzke
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
03a16e9
@JosefBredereck
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8ccef04
@mfranzke
Merge branch 'dev' into 1239-deprecate-mustache-as-default-engine

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8556478
@JosefBredereck JosefBredereck mentioned this pull request Feb 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sghoweri sghoweri

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
breaking ❗ Use this labe if the change will break the current pattern lab behavior dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Mustache as default engine
2 participants
@mfranzke @JosefBredereck