Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LESS to PatternFly core #676

Open
dtaylor113 opened this issue Nov 16, 2017 · 0 comments
Open

Update LESS to PatternFly core #676

dtaylor113 opened this issue Nov 16, 2017 · 0 comments

Comments

@dtaylor113
Copy link
Member

dtaylor113 commented Nov 16, 2017

Move as much angluar-patternfly LESS files into PatternFly core. Determine why we needed the less files in a-pf and if we could add those settings to PF core less files. which ones make sense? Is it because PF core doesn’t have the feature or because A-PF structured NEEDS to be different.

This is also important to reduce LESS usage in angular-patternfly because going forward we also need to support SASS, so the less css in angular-patternfly the better. Ideally, it should all be in PF core.

There are currently 12 less files in angular-patternfly which are canidates:

@import "misc.less";
@import "../src/card/card.less";           <--- Aimee
@import "../src/charts/charts.less";       <--- Dave
@import "../src/views/views.less";
@import "../src/toolbars/toolbars.less";
@import "../src/filters/filters.less";
      Need to match core filter less:  https://github.com/patternfly/patternfly/pull/894
@import "../src/sort/sort.less";
@import "../src/notification/notification.less";
@import "../src/views/listview/list-view.less";
@import "../src/table/table.less";
@import "../src/wizard/wizard.less";
@import "../src/pagination/pagination.less";

Unique to A-PF. PF core doesn't have these components:

@import "../src/canvas-view/canvas/canvas.less";
@import "../src/canvas-view/canvas-editor/canvas-editor.less";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants