Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(DescriptionList): added keyboard interaction cypress test #11689

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(DescriptionList): added keyboard interaction cypress test #11689

wants to merge 2 commits into from
+21 −1

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Mar 18, 2025

Closes #11554

@Mash707
Copy link
Contributor Author

Mash707 commented Mar 18, 2025

I have added keyboard testing for enter key, should I also include a test for spacebar key?
#11546

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 18, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11689.surge.sh

A11y report: https://patternfly-react-pr-11689-a11y.surge.sh

@thatblindgeye
Copy link
Contributor

@Mash707 We should, yes. Since the help text is given the semantic role of a button, we want to ensure it behaves like a button would where both Enter and Space key can trigger/activate a button.

thatblindgeye
thatblindgeye reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. In addition to the above, can we just update the test that was already there to have a description of "Verify list with help text triggered with mouse", and have the new test(s) for keyboard match similarly?

@Mash707
Copy link
Contributor Author

Mash707 commented Mar 19, 2025

This looks good. In addition to the above, can we just update the test that was already there to have a description of "Verify list with help text triggered with mouse", and have the new test(s) for keyboard match similarly?

Sure, will update the description.

@Mash707 Mash707 force-pushed the add-keyboard-interaction-cypress-test branch from 8a0de0b to 9bbe6a8 Compare March 19, 2025 20:10
@Mash707 Mash707 requested a review from thatblindgeye March 19, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DescriptionList - add keyboard interaction cypress test
3 participants
@Mash707 @patternfly-build @thatblindgeye