feat(React19): Enable React19 #725
Open
+1,457
−1,119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebeccaalpert
force-pushed
the
react19
branch
5 times, most recently
from
dc50285 to
66b217a
Compare
2 tasks
rebeccaalpert
changed the title
rebeccaalpert
requested review from
kmcfaul and
a team
and removed request for
a team
rebeccaalpert
force-pushed
the
react19
branch
9 times, most recently
from
ee576b6 to
71cb6f0
Compare
|
@karelhala the changes should be fine. The only real breaking changes were the removal of prop types which are not used here anyway. I might have some time tomorrow, but the fact the Cypress tests are passing is a good enough sign to me that the runtime is not broken. |
nicolethoen
approved these changes
May 6, 2025
rebeccaalpert
force-pushed
the
react19
branch
2 times, most recently
from
529ef83 to
71cb6f0
Compare
|
@rebeccaalpert could you rename this PR and your first commit message so that this is a |
rebeccaalpert
changed the title
|
All set! |
kmcfaul
approved these changes
May 15, 2025
| }, | ||
| "devDependencies": { | ||
| "@patternfly/patternfly-a11y": "^5.1.0", | ||
| "@patternfly/documentation-framework": "^6.5.16", | ||
| "@patternfly/react-code-editor": "^6.0.0", | ||
| "@patternfly/patternfly": "^6.0.0", | ||
| "@types/react": "^18.2.33", | ||
| "@types/react-dom": "^18.3.1", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not run into the same circular dependency issues as I did in ChatBot, but changing the React dev dependency breaks the docs framework. It does build with every React version, but the docs framework stops working with 19. Leaving the dev dependency at 18 for now until we can drop the docs framework.