Skip to content

Passing block to the asssistant initializer #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Passing block to the asssistant initializer #135

wants to merge 1 commit into from

Conversation

mengqing
Copy link
Contributor

@mengqing mengqing commented Feb 19, 2025 •
edited
Loading

This fixes the Assistant initializer not passing the block used for streaming option

Elmolesto
Elmolesto approved these changes Apr 20, 2025
View reviewed changes
Copy link

@Elmolesto Elmolesto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing on linting. Thanks for adding this :)

CC @andreibondarev

@mengqing
Copy link
Contributor Author

The failing lint seems to be unrelated to the changes to this PR. Should it be handled in another PR?

@Elmolesto
Copy link

The failing lint seems to be unrelated to the changes to this PR. Should it be handled in another PR?

I think so..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Elmolesto Elmolesto Elmolesto approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mengqing @Elmolesto