Support for Marshalling to Proto Objects #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
commented
Aug 7, 2024
| // Marshal will take a set of layers and encode them into a Mapbox Vector Tile format. | ||
| // Features that have a nil geometry, for some reason, will be skipped and not included. | ||
| func Marshal(layers Layers) ([]byte, error) { | ||
| vt, err := MarshalToVectorTile(layers) |
There was a problem hiding this comment.
pretty straight forward, i just moved the guts out into another function right before marshalling to bytes. and leave the proto marshaling here for callers of this function
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi! would you be willing to support a slight refactor to marshal not just to bytes but rather to the precursor mvt spec proto objects? this is useful for grpc services which will automatically do the marshalling to bytes as part of their request handling. ive not tested this but wanted to do the PR as an illustration. let me know if its something you'd be ok supporting or not and i can write tests and clean it up if so!