Improve types #25
Merged
Improve types #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option removes `undefined` from number and boolean values and provides default values with `0` and `false`, respectively. PocketBase does this automatically under the hood, but this is not reflected in the collection schema.
# [2.2.0-next.1](v2.1.0...v2.2.0-next.1) (2025-01-19) ### Features * **schema:** add option to improve types ([d8c9780](d8c9780))
Using `z.default` adds `undefined` to generated types. Not sure why, since I explicitly provide a default value so that the property cannot be `undefined` but well... More info: https://stackoverflow.com/questions/76396222/zod-using-optional-with-default-infers-the-wrong-type
# [2.2.0-next.2](v2.2.0-next.1...v2.2.0-next.2) (2025-01-20) ### Bug Fixes * **schema:** remove default values from improved types ([82b6b70](82b6b70))
|
🎉 This PR is included in version 2.2.0-next.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
lujoho
reviewed
Jan 21, 2025
lujoho
reviewed
Jan 21, 2025
lujoho
reviewed
Jan 21, 2025
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This
improveTypesoption removesundefinedfrom number and boolean values. PocketBase does return0andfalseautomatically, but this is not reflected in the collection schema.