Implement Response Caching for Currency and Institution Endpoints #394
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,19 +6,22 @@ toolchain go1.23.6 | |
|
|
||
| require ( | ||
| github.com/JGLTechnologies/gin-rate-limit v1.5.4 | ||
| github.com/alicebob/miniredis/v2 v2.34.0 | ||
| github.com/anaskhan96/base58check v0.0.0-20181220122047-b05365d494c4 | ||
| github.com/btcsuite/btcd/btcec/v2 v2.3.2 | ||
| github.com/chadsr/logrus-sentry v0.4.1 | ||
| github.com/getsentry/sentry-go v0.13.0 | ||
| github.com/gin-gonic/gin v1.9.1 | ||
| github.com/go-co-op/gocron v1.35.0 | ||
| github.com/go-redis/redismock/v9 v9.2.0 | ||
| github.com/golang-jwt/jwt/v5 v5.0.0 | ||
| github.com/jarcoal/httpmock v1.3.1 | ||
| github.com/mailgun/mailgun-go/v3 v3.6.4 | ||
| github.com/mattn/go-sqlite3 v1.14.16 | ||
| github.com/opus-domini/fast-shot v0.10.0 | ||
| github.com/paycrest/tron-wallet v1.0.13 | ||
| github.com/prometheus/client_golang v1.16.0 | ||
| github.com/redis/go-redis/v9 v9.2.0 | ||
| github.com/sendgrid/sendgrid-go v3.14.0+incompatible | ||
| github.com/sirupsen/logrus v1.9.3 | ||
| github.com/spf13/viper v1.16.0 | ||
|
|
@@ -35,6 +38,8 @@ require ( | |
| github.com/Microsoft/go-winio v0.6.1 // indirect | ||
| github.com/alicebob/miniredis/v2 v2.35.0 // indirect | ||
| github.com/apparentlymart/go-textseg/v15 v15.0.0 // indirect | ||
| github.com/alicebob/gopher-json v0.0.0-20230218143504-906a9b012302 // indirect | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/bits-and-blooms/bitset v1.7.0 // indirect | ||
| github.com/bmatcuk/doublestar v1.3.4 // indirect | ||
| github.com/btcsuite/btcd v0.22.1 // indirect | ||
|
Contributor
There was a problem hiding this comment. 🧩 Analysis chainCritical upstream vulns present (btcd). OSV flags multiple critical advisories for github.com/btcsuite/btcd v0.22.1 (indirect). Not introduced by this PR, but it’s a material risk. Consider upgrading or constraining transitive deps pulling btcd, or vendor a patched version. Run to list advisories and reverse-deps: 🏁 Script executed: #!/bin/bash
# Show advisories
gh api graphql -f query='
{ securityVulnerabilities(first: 20, ecosystem: GO, package: "github.com/btcsuite/btcd") {
nodes { advisory { summary severity permalink } vulnerableVersionRange firstPatchedVersion { identifier } }
}
}
'
# Who pulls btcd in module graph
go mod graph | rg -nP 'btcsuite/btcd@' -C2Length of output: 6138 Critical upstream vulns present (btcd v0.22.1). 🤖 Prompt for AI Agents |
||
|
|
@@ -69,17 +74,16 @@ require ( | |
| github.com/klauspost/compress v1.16.7 // indirect | ||
| github.com/mailru/easyjson v0.0.0-20180823135443-60711f1a8329 // indirect | ||
| github.com/mattn/go-runewidth v0.0.14 // indirect | ||
| github.com/matttproud/golang_protobuf_extensions v1.0.4 // indirect | ||
| github.com/mmcloughlin/addchain v0.4.0 // indirect | ||
| github.com/mr-tron/base58 v1.2.0 // indirect | ||
| github.com/pkg/errors v0.9.1 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| github.com/prometheus/client_model v0.4.0 // indirect | ||
| github.com/prometheus/common v0.44.0 // indirect | ||
| github.com/prometheus/procfs v0.11.0 // indirect | ||
| github.com/rivo/uniseg v0.4.4 // indirect | ||
| github.com/robfig/cron/v3 v3.0.1 // indirect | ||
| github.com/sendgrid/rest v2.6.9+incompatible // indirect | ||
| github.com/sergi/go-diff v1.3.1 // indirect | ||
| github.com/shengdoushi/base58 v1.0.0 // indirect | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guard against empty CACHE_VERSION to avoid “:api:*” keys.
If CACHE_VERSION is unset, keys become “:api:*”, which breaks consistency and tests. Default to "v1".
Apply:
type RedisConfiguration struct { Host string Port string Password string DB int - CacheVersion string + CacheVersion string } func RedisConfig() RedisConfiguration { - return RedisConfiguration{ + cv := viper.GetString("CACHE_VERSION") + if cv == "" { + cv = "v1" + } + return RedisConfiguration{ Host: viper.GetString("REDIS_HOST"), Port: viper.GetString("REDIS_PORT"), Password: viper.GetString("REDIS_PASSWORD"), DB: viper.GetInt("REDIS_DB"), - CacheVersion: viper.GetString("CACHE_VERSION"), + CacheVersion: cv, } }Also applies to: 25-26
🤖 Prompt for AI Agents