Skip to content

fix: add Salvadoran Colón currency entry to currenciesCodes.json#32

Open
Dprof-in-tech wants to merge 1 commit intomainfrom
feat-add-El-Sal-vador-currency-SVC
Open

fix: add Salvadoran Colón currency entry to currenciesCodes.json#32
Dprof-in-tech wants to merge 1 commit intomainfrom
feat-add-El-Sal-vador-currency-SVC

Conversation

@Dprof-in-tech
Copy link
Copy Markdown
Collaborator

@Dprof-in-tech Dprof-in-tech commented Feb 2, 2026

Description

This pull request adds a new entry to the currenciesCodes.json data file, expanding support for currency information.

Data update:

  • Added the Salvadoran Colón (SVC) currency with country code SV to the currenciesCodes.json file.

References

closes #31

Testing

Screenshot 2026-02-02 at 3 13 48 AM
  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation and tests for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.

Summary by CodeRabbit

  • New Features
    • Added support for Salvadoran Colón currency in the app, enabling full transaction capabilities for the region.

✏️ Tip: You can customize this high-level summary in your review settings.

@Dprof-in-tech Dprof-in-tech requested a review from chibie as a code owner February 2, 2026 02:14
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

A new currency entry for El Salvador (country code "SV") with currency code "SVC" and currency name "Salvadoran Colón" is added to the currencies codes data file, maintaining alphabetical order between existing entries.

Changes

Cohort / File(s) Summary
Currency Data Addition
src/data/currenciesCodes.json
Added new currency entry for El Salvador's Salvadoran Colón (SVC) to the currencies list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • chibie

Poem

🐰 A colón hops into our list so fine,
El Salvador's currency now will shine,
Five little lines, a data delight,
Another nation's wealth, gleaming bright! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding a Salvadoran Colón currency entry to the currenciesCodes.json file, matching the file modification shown in the changeset.
Description check ✅ Passed The PR description includes Description, References, Testing, and Checklist sections from the template. However, the Testing section lacks detail about how reviewers can verify the change, and the documentation/tests checklist items are unchecked despite being required.
Linked Issues check ✅ Passed The PR adds the SVC currency entry to currenciesCodes.json, directly addressing the core technical requirement from issue #31 to add SVC to the currency list.
Out of Scope Changes check ✅ Passed The PR contains only the single, focused change of adding a Salvadoran Colón entry to currenciesCodes.json, which is directly aligned with the scope defined in issue #31.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-add-El-Sal-vador-currency-SVC

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADD EL SAVADOR COLON TO NOBLOCKS RATES

1 participant