Clean up e2e test temp dirs on panic #565
Merged
+20
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decided against using panic hooks for this work as the moving the `PathBufs` ended up looking ugly. Instead we introduce a `CleanupGuard` struct which when dropped will clean up the temp `PathBufs`. For this I needed to refactor `cleanup_temp_file` to use `std::fs` sync method instead of `tokio::fs` as `Drop` does not have access to the async runtime. Issue: payjoin#564
Pull Request Test Coverage Report for Build 13703437770Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided against using panic hooks for this work as the moving the
PathBufsended up looking ugly. Instead we introduce aCleanupGuardstruct which when dropped will clean up the tempPathBufs. For this I needed to refactorcleanup_temp_fileto usestd::fssync method instead oftokio::fsasDropdoes not have access to the async runtime.Issue: #564