fix(templates): improve creating slugs by triming first #14421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when you are creating slugs and leave spaces on beggining or the end, they will be replaced with hyphen, this enhancement avoids trims unwanted spaces first.
MichalKormanik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you are creating slugs and leave spaces on beggining or the end, they will be replaced with hyphen, this enhancement avoids trims unwanted spaces first.
What?
Utilities for creating slugs from titles
Why?
Badly created slug with hyphen in the end, when user added title with space.
How?
Adding simple
trim()function before replacing spaces with hyphens