Changing the implementation of the joinWithIndex to use the B-Tree #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… get file instead of reading the entire file
uzadude
reviewed
Jan 4, 2023
| kvIt.next() | ||
| } | ||
| if (!kvIt.hasNext || cmp>0) | ||
| val a = avroBtreeStorageFileReader.get(key1GR) |
There was a problem hiding this comment.
not sure that this is the correct baseline to compare, as I have a feeling that it will be much worse then just reading through all the index file (as was before). Even now after fixing #73 it should be much faster.
|
Where is the change to joinByIndex? Why would it be faster if using the btree? joinByIndex already has all the indexes (offsets), it doesn't need to check the btree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of reading the entire file
Summary
resolves #PR/#Issue
don't forget:
Detailed Description
explain the implementation, what is the problem? how did you solve it?
How was it tested?
(unit test/integration test)