Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check formatting πŸ‘Ύ #2440

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ jobs:
with:
useLockFile: false

- name: ▢️ Check Formatting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this isn't in the lint task, we should probably put it there

run: npm run format:check

- name: ▢️ Run Lint
run: npm run lint

Expand Down
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ build
dist
coverage
CHANGELOG.md
.husky/_
22 changes: 12 additions & 10 deletions src/zoid/card-fields/component.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ const CARD_FIELD_TYPE = {
};

type InstallmentsConfiguration = {|
financingCountryCode : string,
currencyCode : string,
billingCountryCode : string,
amount : string,
includeBuyerInstallments ? : boolean
financingCountryCode: string,
currencyCode: string,
billingCountryCode: string,
amount: string,
includeBuyerInstallments?: boolean,
|};

type CardFieldsProps = {|
Expand Down Expand Up @@ -108,10 +108,12 @@ type CardFieldsProps = {|
hcfSessionID: string,
partnerAttributionID: string,
merchantID: $ReadOnlyArray<string>,
installments? : {|
onInstallmentsRequested : () => InstallmentsConfiguration | ZalgoPromise<InstallmentsConfiguration>,
onInstallmentsAvailable : (Object) => void,
onInstallmentsError? : (Object) => void
installments?: {|
onInstallmentsRequested: () =>
| InstallmentsConfiguration
| ZalgoPromise<InstallmentsConfiguration>,
onInstallmentsAvailable: (Object) => void,
onInstallmentsError?: (Object) => void,
|},
|};

Expand Down Expand Up @@ -439,7 +441,7 @@ export const getCardFieldsComponent: () => CardFieldsComponent = memoize(
installments: {
type: "object",
required: false,
value: ({ props }) => props.parent.props.installments
value: ({ props }) => props.parent.props.installments,
},
},
});
Expand Down
Loading