Fix Discriminator with Composed Bundling - #443
Conversation
Update discriminator mappings when external schemas are moved to components during composed bundling. Discriminator mappings act like $ref but aren't technically $ref nodes, so they need separate handling to rewrite external references to component references. - Add comprehensive test coverage for various edge cases - Reuse existing reference rewriting infrastructure - Handle mixed internal/external mappings gracefully - Support oneOf/anyOf discriminator patterns - Preserve invalid references unchanged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 169 169
Lines 23107 23170 +63
=======================================
+ Hits 23025 23088 +63
Misses 77 77
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think I'll consolidate the tests, not sure if we need like 7 discriminator tests, rather than 1 test that has all the cases |
It does not bother me, I actually prefer individual tests, it makes debugging specific parts of units easier in my opinion. |
|
ahh I didn't even see you merged this. I appreciate it a lot!!! |
2 participants
Composed Bundling Changes
fixes #433