Investigate issue 379: Duplicate Parameters

[califlower]

Theoretically fixes #379

I think the expectation in that issue is wrong

For both the specs above we should get 3 parameters when calling GetAllParametersFromOperations and drilling into the parameters within the operation

The openapi 3.0.3 Spec says

A list of parameters that are applicable for all the operations described under this path. These parameters can be overridden at the operation level, but cannot be removed there. The list MUST NOT include duplicated parameters. A unique parameter is defined by a combination of a name and location. The list can use the Reference Object to link to parameters that are defined at the OpenAPI Object’s components/parameters.

The example posted in my mind should return 2 in both scenarios not 3, while logging the error as you do for some of the other operations. But up for debate. I'm not really 100% sure which direction to go. A case could be made that a dupe param should hard fail, since we wouldn't know which one to pick

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.67%. Comparing base (3c96307) to head (fc0c19a).
⚠️ Report is 50 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files         169      169           
  Lines       24604    24606    +2     
=======================================
+ Hits        24525    24527    +2     
  Misses         74       74           
  Partials        5        5           

Flag	Coverage Δ
unittests	99.67% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[daveshanley]

This has been fully implemented in v0.28.2. Thank you for your identification of the issue!