feat(riff): add RF64/BW64 format support#447
Open
tphakala wants to merge 1 commit intopdeljanov:dev-0.6from
Open
feat(riff): add RF64/BW64 format support#447tphakala wants to merge 1 commit intopdeljanov:dev-0.6from
tphakala wants to merge 1 commit intopdeljanov:dev-0.6from
Conversation
Add support for RF64/BW64 audio files, enabling playback of WAV files exceeding the 4GB RIFF size limit per EBU Tech 3306. - Add Ds64Chunk parser for 64-bit sizes (riff_size, data_size, sample_count) with table entry skipping - Detect RF64 stream marker alongside standard RIFF in try_new - Use ds64 values only when 32-bit sentinel (0xFFFFFFFF) is present - Prefer ds64 sample_count over fact chunk for RF64 files - Add RF64 probe descriptor and accept RF64 marker in scoring - Use checked arithmetic for data_start_pos + data_len overflow safety - Add unit tests for ds64 parsing and RF64 integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds RF64/BW64 format support to the WAV demuxer, enabling playback of audio files exceeding the 4GB RIFF size limit.
RF64stream marker alongside standardRIFF0xFFFFFFFF) is present, per specEBU Tech 3306 compliance
-1(sentinel)Context
Fresh rewrite of #425 for
dev-0.6as requested. The original PR targetedmasterbut a mechanical rebase failed due to significant API changes in dev-0.6 (lifetimes onWavReader,FormatInfo/MetadataInfoconstants,Trackconstruction,DataChunk.lenasOption<u32>, etc).Test plan
cargo check -p symphonia-format-riff(all platforms)cargo test -p symphonia-format-riff(11/11 pass)cargo clippy -p symphonia-format-riff(clean)Note: Rustfmt CI may fail due to pre-existing formatting issues in
aiff/mod.rsandfix_wave_channel_maskon thedev-0.6branch — unrelated to this change.