feat: implement relative path normalization for external files in SdistBuilder - #309
Merged
Conversation
…stBuilder Signed-off-by: Frost Ming <me@frostming.com>
✅ Deploy Preview for pdm-backend-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Frost Ming <me@frostming.com>
…test_sdist_rewrites_project_files_outside_project_root Signed-off-by: Frost Ming <me@frostming.com>
| self._show_add_file(relpath, path) | ||
|
|
||
| pkg_info = str(self.config.validate().as_rfc822()).encode("utf-8") | ||
| pkg_info = str(self._metadata.as_rfc822()).encode("utf-8") |
Contributor
There was a problem hiding this comment.
Not really leaving a full code review since you didn't ask, but this change (and setting _metadata from self.config above) doesn't immediately make sense to me, because "metadata" is used elsewhere to refer to just the project table (in Config).
But its a mild naming question, feel free to disregard
Contributor
Author
There was a problem hiding this comment.
That is because the return value of config.validate() is a StandardMetadata, and this property is only for caching and not used elsewhere.
Signed-off-by: Frost Ming <me@frostming.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frost Ming me@frostming.com