fix: relax Client constructor cfg typing#138
Open
anzzyspeaksgit wants to merge 1 commit intopeeringdb:masterfrom
Open
fix: relax Client constructor cfg typing#138anzzyspeaksgit wants to merge 1 commit intopeeringdb:masterfrom
anzzyspeaksgit wants to merge 1 commit intopeeringdb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #134
Description
This addresses the issue with the overly strict type annotation on the
Clientconstructor'scfgparameter. Sincedictis invariant,mypycorrectly rejects valid nested configurations passed as dictionaries (e.g.dict[str, dict[str, object]]).By changing the type hint from
Optional[dict[str, object]]toOptional[Mapping[str, Any]], it now safely accepts user-supplied dictionaries containing nested configuration dictionaries without raisingmypytype errors.Using
Mappinginstead ofdictensures covariance, which fixes the problem.