Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --depth. Fixes #21 #22

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

hildjj
Copy link
Contributor

@hildjj hildjj commented Feb 27, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 99.45%. Comparing base (5a0e9cc) to head (19cd5ae).

Files Patch % Lines
lib/cli.js 84.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #22      +/-   ##
===========================================
- Coverage   100.00%   99.45%   -0.55%     
===========================================
  Files            2        2              
  Lines          350      366      +16     
===========================================
+ Hits           350      364      +14     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hildjj
Copy link
Contributor Author

hildjj commented Feb 27, 2024

@nichtich please review.

@nichtich
Copy link

Thanks, works like needed! I'd only change the help messages to avoid a line break:

  -d,--depth <number>      Maximum depth to expand references (default: 0)
  -e,--expand              Expand rule references without depth limit

@hildjj hildjj merged commit e6ccc99 into peggyjs:main Feb 28, 2024
3 checks passed
@hildjj hildjj deleted the expand-depth branch February 28, 2024 16:06
@hildjj
Copy link
Contributor Author

hildjj commented Feb 28, 2024

Fixed in v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants