Fix flaky allocation test - #2465
Merged
Merged
Conversation
FindAssignableAllocationServiceTest creates allocations on ports 5000-5005 using the same node and ip as the server's own factory allocation. That allocation gets a random port from 1024-65535, so once in a while it lands inside that range and the unique (node_id, ip, port) index fails the test. Raise the factory floor to 10000 so they can never overlap.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe allocation factory now generates ports from ChangesAllocation factory generation
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allocation factory picks a random port between 1024 and 65535, and a few tests hardcode ports 5000-5005 on the same node and ip as the server's factory allocation. When the random port happens to land in that range, the unique (node_id, ip, port) index fails the test - the SQLite job on #2464 hit exactly this. Raise the factory floor to 10000 so the two can never overlap.