genimage: allow non-sparse image-less partitions not in partition table #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, partitions not included in a partition table were required
to always reference an image.
However, it can be useful to define such partitions without an image,
for example, for "barebox-env" or "barebox-state" regions at fixed
offsets in legacy MBR setups. These partitions are typically populated at
runtime and therefore do not need an image.
To ensure that flashing a sparse image variant results in a well-defined
state, these partitions should be explicitly filled with zeros to
overwrite any existing data.
So allow partitions not present in the partition table, without an
image, to be filled with zeros, e.g.:
partition barebox-environment {
size = 128K
in-partition-table = false
sparse = false
}
Signed-off-by: Bastian Krause <[email protected]>
Bastian-Krause
force-pushed
the
bst/zeroed-imageless-part-not-in-parttable
branch
from
d2c65f8 to
6ab44d5
Compare
Bastian-Krause
deleted the
bst/zeroed-imageless-part-not-in-parttable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, partitions not included in a partition table were required to always reference an image.
However, it can be useful to define such partitions without an image, for example, for "barebox-env" or "barebox-state" regions at fixed offsets in legacy MBR setups. These partitions are typically populated at runtime and therefore do not need an image.
To ensure that flashing a sparse image variant results in a well-defined state, these partitions should be explicitly filled with zeros to overwrite any existing data.
So allow partitions not present in the partition table, without an image, to be filled with zeros, e.g.: