Add support for non-integer PKs #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good to me, and the tests pass, but I'm wondering about how querysets and the ORM handle the different types. Does django not care if you pass in a string or an int for a CharField / AutoField? Will it coerce to the proper type before firing off the SQL query? I'll look into the docs a bit more but wanted to ask in case you had experience with this. |
|
I would suspect it works fine since the original tests are passing and their pks are being cast to strings as well |
|
@davish I just verified it and it works: Django will find instances by their PK even if it's passed as a string and the actual value is an int |
Previously modifying other instances in the queryset would trigger messages for all "retrieve" subscriptions
|
@davish I fixed a bug where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to broadcast updates for models that don't use integer PKs, for example UUID or HashID. The biggest change is converting
pks_in_querysetto a set of strings (instead of integers). This will support any type that can be reliably cast to a string.