Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVEREST-1819 [CLI] Get rid of spf13/viper lib for parsing CLI params #1015

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

maxkondr
Copy link
Contributor

  • Use spf13/cobra lib only for parsing CLI params
  • Parse global flags (--verbose, --json, --kubeconfig) on root level
  • Extend examples

- Use spf13/cobra lib only for parsing CLI params
- Parse global flags (--verbose, --json, --kubeconfig) on root level
- Extend examples
@maxkondr maxkondr requested a review from a team as a code owner January 16, 2025 20:05
@maxkondr maxkondr self-assigned this Jan 16, 2025
Copy link
Member

@mayankshah1607 mayankshah1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions to consider :)

Overall LGTM, great improvements. Thanks!

pkg/cli/install/install.go Show resolved Hide resolved
commands/install.go Show resolved Hide resolved
commands/namespaces.go Show resolved Hide resolved
commands/accounts.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants