-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPG-708 replace ready/live probe http check with custom command, change pg entrypoint #1099
base: K8SPG-613
Are you sure you want to change the base?
Conversation
internal/patroni/reconcile.go
Outdated
container.LivenessProbe.Exec = &corev1.ExecAction{ | ||
Command: []string{"/usr/local/bin/postgres-liveness-check.sh"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we want to do this change only for >2.7.0 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done here: c377050
The e2e tests are failing because the init image used is the operator's main image, and it does not contain the related .sh files that need to be installed to the instance pod volume. Changing the following:
Notice the With this addition tests should pass. |
Note that this PR has base branch |
commit: 8481dfc |
CHANGE DESCRIPTION
Problem:
We are changing the probes from direct requests to patroni's restful api to a custom command so that we can get more flexibility on what can be executed for the live/ready checks of the pg container. For now this is needed so that we can introduce a sleep forever feature.
Deleted related PR: percona/percona-docker#1148
We are also introducing a new entrypoint for the database container which is defined in the percona-docker repo for now.
Testing sleep forever
Checking the creation of the /tmp/postgres file and verifying that
pg_ctl -D /pgdata/pg17 start
starts as expectedCause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
Config/Logging/Testability