-
Notifications
You must be signed in to change notification settings - Fork 11
PMM-14577 Fix CVEs by bump versions. #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ademidoff @idoqo @svetasmirnova I don’t have permission to push to Percona PMM Dump, so I created a fork. It would be great if I could get the necessary permissions.
|
I don't have access to that namespace of Snyk either, the access is granted on a per-team basis. |
idoqo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JiriCtvrtka i think PR should be against pmm-3.4.1 branch since:
- it's the branch on pmm-submodules.
- we haven't tested/updated pmm to use changes from main branch (e.g encryption).
| github.com/grafana/grafana v0.0.0-20240319182150-590c657828b5 | ||
| github.com/grafana/grafana-plugin-sdk-go v0.281.0 | ||
| github.com/hashicorp/go-version v1.7.0 | ||
| github.com/grafana/grafana v1.9.2-0.20240724181030-49c756d77483 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicee, this resolves cves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is latest one I was able to find and it is working. One mentioned in CVE report: 1.9.2-0.20250521205822-0ba0b99665a9 is not existing for me. So I am going to check report if this one is fine.
go: github.com/grafana/[email protected]: invalid version: unknown revision 1.9.2-20250521205822-0ba0b99665a9
osr-mb-044:tools jiri.ctvrtka$ go get github.com/grafana/[email protected]
go: github.com/grafana/[email protected]: invalid version: unknown revision 0.1.9.2-20250521205822-0ba0b99665a9
@idoqo I see, ok let me fix it. |
a13cf89 to
dcc41fb
Compare
|
We agreed to merge this PR and then review the new vulnerability report. If needed, another iteration will be done. |
I dont have permissions to push into Percona PMM Dump. So I created fork.
Ticket: https://perconadev.atlassian.net/browse/PMM-14577
PMM PR: percona/pmm#4848